Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with new IntelTip option #17

Open
aleeperezz16 opened this issue May 16, 2020 · 14 comments
Open

Bug with new IntelTip option #17

aleeperezz16 opened this issue May 16, 2020 · 14 comments

Comments

@aleeperezz16
Copy link

Minutes ago the plugin got updated and since then i'm having this scheme bug. Also even though i turn off the new setting:

"enable_inteltip_calls"

Neither restarting sublime text takes effect on this.

Img showing the syntax bug:

imagen

@voed
Copy link

voed commented May 16, 2020

Same. Also this intellitip works weird, it does not show up when caret inside function's parenthesis, it shows up only on mouse click, maybe there are some settings for it?

@evandrocoan
Copy link
Owner

I just launched a new update fixing some problems. Now the enable_inteltip_calls works correctly to disable things.

@aleeperezz16 What is wrong in the screenshot? To me, everything looks normal.

@aleeperezz16
Copy link
Author

aleeperezz16 commented May 18, 2020

What i meant was that before the update, non AmxxEditor color schemes didn't show the function parameters as a "function" with that color blue (One Dark Theme). Before that, it looked white like simple text. As you can barely see the variable g_Class has normal text color.

@voed
Copy link

voed commented May 18, 2020

Just suggestion: move links to bottom and make function name and return value single line so it will use less space:
image
Also highlight current parameter in parameter list(if that possible)

@evandrocoan
Copy link
Owner

evandrocoan commented May 19, 2020

@aleeperezz16, after the latest updates I released, do you still have any issues?

@voed, I just implemented support to highlight the active parameter and moved the function return type to the side of the function name but I kept the links on the top because sometimes there will be a scrollbar on the popup, making hard to see the links:

image

@aleeperezz16
Copy link
Author

The IntelTip now works as it should but i still have the variables for my function parameters shown as a function (with the same color). However this happens only on non predefined themes of AmxxEditor. If it's hard to solve i will just use atomic-pawn theme instead...

@evandrocoan
Copy link
Owner

the variables for my function parameters shown as a function (with the same color)

This happens because I extended the scope of the function to include the function parameters. This is easily fixed, but you will have to edit the color scheme you are using. What are the color schemes you are having trouble with?

@aleeperezz16
Copy link
Author

I'm using One Dark Theme so it's not an official AmxxEditor theme. Otherwise i also discovered that the official theme white-pawn has the same problem.

@evandrocoan
Copy link
Owner

I just fixed the problem with white-pawn theme. You can see here 97471bc the changes which need to be done. Basically, we just have to exclude -support.function.call.paren from the support.function colors.

@aleeperezz16
Copy link
Author

aleeperezz16 commented May 19, 2020

Well, i was able to change it:
imagen

Unfortunately, functions called inside a function aren't recognized as functions. Anything else i should touch or add on the tmTheme file to make it work?

@evandrocoan
Copy link
Owner

I just released an updating fixing it. You also do not need to edit your tmTheme files anymore.

@aleeperezz16
Copy link
Author

aleeperezz16 commented May 19, 2020

I've installed AmxxPawn plugin and that got fixed. On the other hand, i don't know why this syntax isn't compatible with the other AmxxEditor color schemes. Also is not full supported by external color schemes.
Here's a pic:
imagen

Enum tagging changed it's colors and inside function parameters got fixed.
Here's another pic of some special words not correctly highlighting or also not getting highlighted:
imagen
imagen
imagen

@evandrocoan
Copy link
Owner

evandrocoan commented May 19, 2020

What is the problem with the pictures? Remember I do not know these (colors) schemes as I use only this https://github.com/evandrocoan/NotepadPlusPlusColorScheme

@aleeperezz16
Copy link
Author

This one is atomic-pawn with AmxxPawn.sublime-syntax:
imagen
This one is atomic-pawn with AmxxEditorPawn.sublime-synxtax:
imagen
What i mean it's that i think you should also update AmxxEditorPawn to work with the new features. Or add to AmxxPawn yo make all syntax work as they should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants