Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Move SaaS connector files inside fidesops directory #1262

Open
galvana opened this issue Sep 6, 2022 · 0 comments
Open

Move SaaS connector files inside fidesops directory #1262

galvana opened this issue Sep 6, 2022 · 0 comments
Labels
enhancement New feature or request fidesops-plus Identifies work that is needed by the fidesops plus team

Comments

@galvana
Copy link
Collaborator

galvana commented Sep 6, 2022

Is your feature request related to a specific problem?



We are currently running into an issue when starting Fidesops-plus since some files cannot be located
<br/>fidesops-plus | INFO:fidesops.main:Validating SaaS connector templates...<br/>fidesops-plus | Traceback (most recent call last):<br/>fidesops-plus | File "/usr/local/bin/fidesops_plus", line 8, in <module><br/>fidesops-plus | sys.exit(main())<br/>fidesops-plus | File "/fidesops_plus/src/main.py", line 56, in main<br/>fidesops-plus | start_webserver()<br/>fidesops-plus | File "/usr/local/lib/python3.9/site-packages/fidesops/main.py", line 234, in start_webserver<br/>fidesops-plus | load_registry(registry_file)<br/>fidesops-plus | File "/usr/local/lib/python3.9/site-packages/fidesops/ops/service/connectors/saas/connector_registry_service.py", line 133, in load_registry<br/>fidesops-plus | _registry = ConnectorRegistry.parse_obj(load_toml([config_file]))<br/>fidesops-plus | File "/usr/local/lib/python3.9/site-packages/fideslib/core/config.py", line 227, in load_toml<br/>fidesops-plus | file_name = load_file(file_names)<br/>fidesops-plus | File "/usr/local/lib/python3.9/site-packages/fideslib/core/config.py", line 218, in load_file<br/>fidesops-plus | raise FileNotFoundError<br/>fidesops-plus | FileNotFoundError<br/>fidesops-plus exited with code 1<br/>
This happens because fidesops-plus cannot locate the data/saas/saas_connector_registry.toml file in fidesops.



Describe the solution you'd like



We want someone who does pip install fidesops to get those data/ files along with all the Fidesops code. This will most likely have to be done by updating the MANIFEST.in to include the updated data directory in the generated package (src/fidesops/data).


@galvana galvana added enhancement New feature or request fidesops-plus Identifies work that is needed by the fidesops plus team labels Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fidesops-plus Identifies work that is needed by the fidesops plus team
Projects
None yet
Development

No branches or pull requests

1 participant