Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate our browser/Node code separation #781

Open
AuHau opened this issue Oct 20, 2022 · 0 comments
Open

Reevaluate our browser/Node code separation #781

AuHau opened this issue Oct 20, 2022 · 0 comments
Labels
type:issue

Comments

@AuHau
Copy link
Contributor

AuHau commented Oct 20, 2022

Currently, we utilize the packageJson.browser field to separate browser and NodeJS nuances especially around the transport layer and things like unavailable Blob in NodeJS etc. Now with Node 18 shipping with default turned on implementation of fetch, the distinction is narrowing down.

We could therefore drop the browser field more or less and have just one logic for the data preprocessing with some conditional imports to setup the correct components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AuHau