Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate proxy detection into the verification flow #1712

Open
6 tasks
Tracked by #1665
manuelwedler opened this issue Oct 22, 2024 · 0 comments
Open
6 tasks
Tracked by #1665

Integrate proxy detection into the verification flow #1712

manuelwedler opened this issue Oct 22, 2024 · 0 comments

Comments

@manuelwedler
Copy link
Collaborator

manuelwedler commented Oct 22, 2024

The PoC we implement in #1655 detects and resolves proxy contracts on the fly when our API is called. It would be nice from a data analysis perspective to mark contracts in our DB as proxies by already running the detection during verification. People using our parquet exports could make use of this data then. Furthermore, we could add EIP1167 contracts to our database (#1624).

The implementation resolution still needs to be done during an API call, because we are not a block explorer and cannot keep track of changed implementations. Only the implementations of EIP1167 contracts could be added to the database (but not necessary as it can be read out of the bytecode very quickly).

Needed changes

  • Specify DB schema change
  • Implement DB schema change
  • Integrate detection into the verification process (should be in server and not in lib-sourcify)
  • Still run proxy resolution on the fly when the API is called
  • Upgrade DB
  • Migrate existing data by running proxy detection on all already verified contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant