Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server's /repository does not return 404 but 200 when there are no files #1629

Open
kuzdogan opened this issue Sep 11, 2024 · 0 comments
Open
Labels
🪲 bug Something isn't working

Comments

@kuzdogan
Copy link
Member

I've noticed when GET'ing a file that does not exist, the server's /repository endpoint does not return a 404 but a 200.

https://sourcify.dev/server/repository/contracts/full_match/11155111/0x0A3CbE147dc7BcF5c48113037FDbb05139E370f5/sources/asdsadsad

Repo works as intended for this example because it doesn't have a file extension like .sol:
https://repo.sourcify.dev/contracts/full_match/11155111/0x0A3CbE147dc7BcF5c48113037FDbb05139E370f5/sources/asdsadsad

But when added a file extension it works similar to above:
https://repo.sourcify.dev/contracts/full_match/11155111/0x0A3CbE147dc7BcF5c48113037FDbb05139E370f5/sources/asdsadsad.sol

@kuzdogan kuzdogan added the 🪲 bug Something isn't working label Sep 11, 2024
@kuzdogan kuzdogan changed the title repo.sourcify.dev redirects to server's /repository does not return 404 but 200 Server's /repository does not return 404 but 200 when there are no files Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant