Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logIdx is calculated incorrectly #124

Open
zilm13 opened this issue Mar 7, 2019 · 0 comments
Open

logIdx is calculated incorrectly #124

zilm13 opened this issue Mar 7, 2019 · 0 comments

Comments

@zilm13
Copy link
Contributor

zilm13 commented Mar 7, 2019

logIdx is currently calculated incorrectly in both usages in Harmony. It starts with 0 on every tx, but should start on block, so first log in tx could easily be greater than 0.
Check specs: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getfilterchanges says the log index is relative to the block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zilm13