Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roughness weights #77

Open
qlahcim opened this issue Feb 29, 2024 · 1 comment
Open

Roughness weights #77

qlahcim opened this issue Feb 29, 2024 · 1 comment
Labels
enhancement help wanted

Comments

@qlahcim
Copy link

qlahcim commented Feb 29, 2024 •
edited
Loading

Any plans to implement roughness weights, which are still not implemented but this is extremely important feature!!! (see #59 (comment) )?
@espdev
Copy link
Owner

espdev commented Mar 1, 2024 •
edited
Loading

@michalkvasnicka,

I agree that this functionality would be useful to have for more precise smoothing control.

I'm not sure I'll be able to get on it anytime soon. Could you implement this functionality and make a PR?
I don't think it should be too difficult. You can see how it is done in csaps.m in MATLAB and port the m-code in Python. Unfortunately, I don't have access to MATLAB right now.

Unlike MATLAB, we can add a new parameter roughness to the classes and csaps function. I don't like MATLAB approach to add this to p (smooth) parameter as a vector of weights on the interval x(i-1),x(i).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@espdev @qlahcim