Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't modify the currently active run when (re-)importing schedules #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

duncte123
Copy link
Contributor

Speedcontrol does not modify the currently active run when overriding the schedule with an import.
The esa-layouts package should adhere to this philosophy so that categories do not get set back to what is on the schedule after an incentivised upgrade for example.

@duncte123 duncte123 requested a review from zoton2 March 26, 2023 18:11
@zoton2
Copy link
Member

zoton2 commented May 14, 2023

Sorry for the late review on this.

My main issue with your current solution is it will also not modify the run stored in the runDataArray replicant in speedcontrol. IIRC that's what should happen if we want to keep to the same philosophy. Right now there's no easy way of doing this beyond modifying the replicants directly ourselves, so I'd need to add something to speedcontrol directly.

@duncte123
Copy link
Contributor Author

Sorry for the late review on this.

My main issue with your current solution is it will also not modify the run stored in the runDataArray replicant in speedcontrol. IIRC that's what should happen if we want to keep to the same philosophy. Right now there's no easy way of doing this beyond modifying the replicants directly ourselves, so I'd need to add something to speedcontrol directly.

Then it seems like this bug needs to be fixed in speedcontrol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants