You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I add some prints to your script and change the macOS's Dark/Light system preference:
Suggested Solution
If instead of using single quotes...
set -g @dark-notify-theme-path-light '$HOME/.config/tmux/plugins/tmux-colors-solarized/tmuxcolors-light.conf'
... I use double quotes...
set -g @dark-notify-theme-path-light "$HOME/.config/tmux/plugins/tmux-colors-solarized/tmuxcolors-light.conf"
... Then this issue does not happen anymore.
I suggest making explicit in the README about this issue (at least happening on macOS) or handling the case in the tmux-theme-mode.sh script of this project.
The text was updated successfully, but these errors were encountered:
eulersson
added a commit
to eulersson/tmux-dark-notify
that referenced
this issue
May 5, 2024
Interesting... Well for now I will leave it with double quotes and leave it as a mystery. If any user experiences this and might help us see what causes this wrong variable expansion it would be great.
It would be nice to reproduce it in a clean macOS environment, but I don't have the time to spend and try it, so from my side if you want to close the issue I would be fine, with the double quotes it works.
Environment
14.4.1
3.5.0beta22
5.9 (x86_64-apple-darwin23.0)
bash3.2.57(1)-release
3.4
Problem
If I follow the instructions and set the
@dark-notify-theme-path-light
or dark equivalent as follows:It won't work and won't be able to resolve the file because the
$HOME
variable won't be expanded:The
theme_path=$(eval echo "$theme_path")
resolves to/$HOME/.config/...
instead of/Users/ramon/.config/...
:tmux-dark-notify/scripts/tmux-theme-mode.sh
Line 48 in 4a205f8
If I add some prints to your script and change the macOS's Dark/Light system preference:
Suggested Solution
If instead of using single quotes...
set -g @dark-notify-theme-path-light '$HOME/.config/tmux/plugins/tmux-colors-solarized/tmuxcolors-light.conf'
... I use double quotes...
set -g @dark-notify-theme-path-light "$HOME/.config/tmux/plugins/tmux-colors-solarized/tmuxcolors-light.conf"
... Then this issue does not happen anymore.
I suggest making explicit in the README about this issue (at least happening on macOS) or handling the case in the
tmux-theme-mode.sh
script of this project.The text was updated successfully, but these errors were encountered: