Use matrix for npm run check:* commands in CI
#1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce duplication and the overall size of the CI configuration by using the fact that all `check:*` commands are more or less identical and can thus perfectly be used in a matricized CI job. This also folds the lockfile and manifest checks (`package.json` and `package-lock.json` in CI) into the main `checks.yml` workflow to further simplify things (the previous setup was chosen to reduce wasting CI cycles on checking these when the files didn't change, but the simplicity of the approach here seems better to me atm). Fingers crossed this isn't going to be a nightmare with `step-security/harden-runner`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1766
Summary
Reduce duplication and the overall size of the CI configuration by using the fact that all
check:*commands are more or less identical and can thus perfectly be used in a matricized CI job.