Harden GitHub Actions workflows #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all GitHub Actions workflows following an analysis by zizmor (https://github.com/woodruffw/zizmor). In particular, this avoids persisting git credentials when the job does not need it (which I believe is all jobs). Zizmor did have one more concern - overly permissive `permissions: read-all` - but this was not addressed because I think this is okay, the project is entirely open so I don't see a risk of an attacker reading anything. Signed-off-by: Eric Cornelissen <ericornelissen@gmail.com>
ericcornelissen
force-pushed
the
harden-ghaw
branch
from
754e9fe
to
3e36bfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update all GitHub Actions workflows following an analysis by zizmor. In particular, this avoids persisting git credentials when the job does not need it (which I believe is all jobs).
Zizmor did have one more concern - overly permissive
permissions: read-all- but this was not addressed because I think this is okay, the project is entirely open so I don't see a risk of an attacker reading anything.Interestingly, this was already the case for the
website.ymlworkflow since #173.