Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping self-redirect #181

Open
FichteFoll opened this issue Nov 15, 2024 · 2 comments
Open

Overlapping self-redirect #181

FichteFoll opened this issue Nov 15, 2024 · 2 comments

Comments

@FichteFoll
Copy link
Contributor

Via #168, "Sengoku Youko: Senma Konton-hen" was redirected to the first season but also to itself, which causes trackma to redirect episodes 14 and following to 1 and following respectively, meaning it cannot detect episode 15. Since I'm on Linux, I don't have taiga to check its behavior, so I'm asking here: Does taiga handle this situation correctly? Is this an issue with the relations file or with trackma?

@erengy
Copy link
Owner

erengy commented Nov 16, 2024

Hey. Just checked, there doesn't seem to be any issues in Taiga:

image

Perhaps it's because Trackma always follows the redirections, while Taiga does it only when it's required? Quoting myself from #27:

Taiga only redirects invalid episode numbers. If it's already within the allowed range, Taiga doesn't check redirections at all. This is intentional, since redirecting valid episode numbers is generally not a good idea.

In any case, the self-redirection indeed tells you to redirect episode 14 and onwards, which can be problematic. I should check if there are any releases for the series where the ! is useful, and any other rules with the same issue.

@FichteFoll
Copy link
Contributor Author

I see. In that case I'll adjust trackma to follow taiga's behavior so that there aren't any conflicts in behavior in this regard, but the redirect itself doesn't make sense in the first place because the self-redirects will be ignored for 14-22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants