Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pagination options through the CLI global arguments #434

Open
displague opened this issue Jan 16, 2024 · 0 comments
Open

Expose pagination options through the CLI global arguments #434

displague opened this issue Jan 16, 2024 · 0 comments

Comments

@displague
Copy link
Member

We're not using the Servicer.Excludes/Includes functions in some of these pagination locations. This is needed to ensure that the --include and --exclude arguments from the CLI make it into the request.

We should introduce --page, --per-page as globals, like include and exclude. These would also be exposed through the Servicer to pass the desired pagination settings into the request. This would allow a user to skip the full list or paginate on their own terms. Sort options (sort_by, sort_dir) would also make sense with --page.

A difference between pagination options and include/excludes, is that the latter are used in all request types while pagination is only used in GET requests.

Originally posted by @displague in #431 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant