Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify geometric shapes management #16

Open
noooway opened this issue Dec 12, 2018 · 0 comments
Open

Simplify geometric shapes management #16

noooway opened this issue Dec 12, 2018 · 0 comments
Labels
enhancement

Comments

@noooway
Copy link

noooway commented Dec 12, 2018

Currently there are a lot of classes of ParticleSources and InnerRegions that differ only by underlying geometic shape, e.g: Inner_region_box, Inner_region_cylinder, Particle_source_box, Particle_source_cylinder etc.
It seems more convenient to extract geometric primitives into separate classes and use objects of such classes inside Particle_source and Inner_region.
See also epicf/ef_python#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noooway