Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objdiff-cli diff: Wishlist #47

Open
2 of 18 tasks
ribbanya opened this issue Mar 1, 2024 · 0 comments
Open
2 of 18 tasks

objdiff-cli diff: Wishlist #47

ribbanya opened this issue Mar 1, 2024 · 0 comments
Labels

Comments

@ribbanya
Copy link
Contributor

ribbanya commented Mar 1, 2024

Some things I think are missing from the diff workflow. Mostly here for discussion and so I don't forget to implement them. Can be broken up into separate issues as necessary (feel free to edit this post).

asm-differ flags

  • --make (requires some restructuring of config structs like BuildConfig)
  • --watch
  • --width
  • --threeway=prev
  • --threeway=base
  • --diff_mode=single
  • --compress-matching
  • --no-pager
  • --format {color,plain,json} (not sure about HTML)

Pager features

  • Center the view on the first change at startup
  • Navigate between changes with ] and [
  • Vim-like search (/ or ? to enter a string, Enter to confirm, n and b to navigate results)
  • Something to go to the top or bottom of the entire diff. In Vim this is G and gg but I'm not sure if we want multi-character keystrokes.

UI

  • Help page with scroll and search features, maybe h to activate?
  • Show number of changes in a status bar somewhere ("1 of 5"). When the view changes, update to the first change in the view (from top to bottom).
  • Show delta in percentage since the last change (red "▼x.xx%" or green "▲x.xx%")
  • Show difference in bytes (raw bytes or as KB, not sure). asm-differ shows score from max_score down to 0 but I don't find that very useful personally.
  • Toggle relaxed relocations with a hotkey
@ribbanya ribbanya changed the title cli diff: Wishlist objdiff-cli diff: Wishlist Mar 2, 2024
@encounter encounter added the cli label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants