Use quoted access for Module['ctx']. NFC
#22882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the last property explicitly listed in the closure type annotate for the `Module` object. This means that it was previously being preserved by closure via this mechanism, but now we preserve it via the normal quoting mechanism. I've been looking at removing `ctx` and `canvas` from the `Module` object, but this change is just about consistency. See emscripten-core#22876
kripken
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the last property explicitly listed in the closure type annotate for the
Moduleobject. This means that it was previously being preserved by closure via this mechanism, but now we preserve it via the normal quoting mechanism.I've been looking at removing
ctxandcanvasfrom theModuleobject, but this change is just about consistency.See #22876