Support itms apps link (open app in app store) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: If you open the website using the Chrome app on iPhone, "download from app store" is not working
Why: Chrome does not support open a link from the AppStore
Solution: Use
itms-app://to open the app from AppStorePossible problem: if the user clicks this link on non-iOS device, then the link is not going to work. But if the user clicks "download from app store" their intent is to "download it from the app store" and they must be on an iOS device. So I think it is okay - I want to leave this up to the person fork the website, so I make it an option in the config file
use_itms_apps_linkLet me know if you have any other solutions or suggestions for this. Thanks!