Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for other Loss systems #77

Open
PonteIneptique opened this issue Dec 6, 2020 · 2 comments
Open

Allow for other Loss systems #77

PonteIneptique opened this issue Dec 6, 2020 · 2 comments

Comments

@PonteIneptique
Copy link
Contributor

Akin to #76, I would like to try Dice Loss for Linear tasks. It's a bit more tricky to implement as it is done in model, and not in Trainer. What do you think ?

@emanjavacas
Copy link
Owner

I'd like to see if that Dice loss can help with any of the tasks more or less reliably. It'd require expanding LinearDecoder. It could be added as an extra decoder class. As far as I understand all ingredients needed to implement it are available to LinearDecoder.loss. In any case, the first thing to do would be to experiment and check for improvements. If you fancy that and have the time go ahead. But if it turns out not to be significantly useful, I'd rather stay away from overcomplicating the code base.

@PonteIneptique
Copy link
Contributor Author

I was thinking we could use model.loss(type=ENUM) or something like this, down the road.
But yes, from what I have seen, I don't expect improvements, I have less hope in this one than I had in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants