Remove window flicker and extend duration with open command #1120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves a problem that had been already solved in 0d1b5e0 but was reintroduced in a9a35c1. Basically before this, the window has been closed and reopened if it existed, which results in flickering due to the animations.
In addition to removing the window flicker the timer (if started with --duration) will also be renewed. This fixes #892.
Additional Notes
open
to apply new settings to a window will be surprised. However, in 0d1b5e0 it was mentioned that this could and should be solved byreload
.--duration
has been supplied, e.g.: I open a window with--duration 4s
after 3s i open the window again but without--duration
-> The window will still close after 1s. This might be counter-intuitive and could be fixed quite easily, I just wasn't sure what behavior to implement.Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/main
directory has been adjusted to reflect my changes.cargo fmt
to automatically format all code before committing