Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Notification Hints in the Server #210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle Notification Hints in the Server #210

wants to merge 3 commits into from

Commits on Jul 12, 2023

  1. handle urgency and desktop-entry hints in the server 

    we already need to check thoses to block the GSD notfications
instead of re-checking they in the notification class, only
get they value one time in notify().

Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
    @Marukesu
    Marukesu committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ca39423 View commit details
    Browse the repository at this point in the history

  2. select the right title in the server 

    the server is now in the responsability in defining the title and body,
if it end up without one of those, we error out. body sanitization was
moved from the bubble to the notification and extented to deal with
carriage returns and force feed characters.

Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
    @Marukesu
    Marukesu committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    337277d View commit details
    Browse the repository at this point in the history

  3. handle image hints in the server 

    the notification have now explicit image and badge properties
the server set them to the right icons, and masking happens in the
bubble. MaskedImage was updated to handle any GLib.LoadableIcon.

Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
    @Marukesu
    Marukesu committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d8e6352 View commit details
    Browse the repository at this point in the history