Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct user to open EX app before starting verification #28520

Open
Tracked by #2464
mxandreas opened this issue Nov 22, 2024 · 10 comments
Open
Tracked by #2464

Instruct user to open EX app before starting verification #28520

mxandreas opened this issue Nov 22, 2024 · 10 comments
Assignees
Labels
A-E2EE-SAS-Verification O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement Team: Crypto X-Needs-Product More input needed from the Product team

Comments

@mxandreas
Copy link

mxandreas commented Nov 22, 2024

When verifying the device with another device, the EX app needs to be open before the verification is started, otherwise the request is lost. This is not ideal, but there is no trivial fix for it. Therefore have chosen to instruct the user to open the app.

On EX side there, there is an extra step between selecting another device as means of verification and actually starting the verification. To keep things currently simple on EW, simply update the copy in this modal:

image

"Verify your identity to access encrypted messages and prove your identity to others. If you use another mobile device, please open the app there before you proceed."

This has already created confusion, thus important to bring some clarity ASAP.

@mxandreas mxandreas added T-Task Tasks for the team like planning Team: Crypto labels Nov 22, 2024
@dosubot dosubot bot added A-E2EE-SAS-Verification O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect labels Nov 22, 2024
@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2024

The user could be using any device to verify it, including another session on the same device, so saying "another mobile device" is very confusing

@t3chguy t3chguy added the X-Needs-Product More input needed from the Product team label Nov 22, 2024
@mxandreas
Copy link
Author

Yes, they could. That is why it is says that if you use a mobile device.

@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2024

"another mobile device"? I don't have "another mobile device" I have just the one

@t3chguy
Copy link
Member

t3chguy commented Nov 22, 2024

When verifying the device with another device, the EX app needs to be open before the verification is started, otherwise the request is lost. This is not ideal, but there is no trivial fix for it.

Where is the issue with context for why this is not fixed?

@mxandreas
Copy link
Author

"another mobile device"? I don't have "another mobile device" I have just the one

I do not think many users run EW on their mobile device, if that is what you meant. "Another mobile device" does not in my opinion suggest that you have multiple mobile devices - it is another device that is mobile. However, I do not mind alternative wordings which may be more clear.

@frebib
Copy link

frebib commented Nov 25, 2024

the EX app needs to be open before the verification is started, otherwise the request is lost.

Classic Element (Android) doesn't have this issue so it doesn't sound like it's impossible to implement. Is this an iOS specific limitation, or just a Hard Problem™ that isn't going to be attempted to be fixed?

@stefanceriu
Copy link
Member

The underlying issue here is that in order to bootstrap the session verification listeners we need access to the user's identity which is dependant on a keys query response. Normally that would be handled through an olm machine listener but, as I understand it, those get reset often due to missing cross proccess locking. As such, we use sync callbacks as a retry mechanism until we can actually get our hands on a session_verification_controller. Obviously, this isn't ideal but the fix isn't at all straight forward.

@florianduros florianduros added T-Enhancement and removed T-Task Tasks for the team like planning T-Defect labels Nov 26, 2024
@BillCarsonFr
Copy link
Member

BillCarsonFr commented Nov 26, 2024

The underlying issue here is that in order to bootstrap the session verification listeners we need access to the user's identity which is dependant on a keys query response. Normally that would be handled through an olm machine listener but, as I understand it, those get reset often due to missing cross proccess locking. As such, we use sync callbacks as a retry mechanism until we can actually get our hands on a session_verification_controller. Obviously, this isn't ideal but the fix isn't at all straight forward.

I thought the issue was that the notification client (EX) was swallowing the to_device verification request events

@richvdh
Copy link
Member

richvdh commented Nov 26, 2024

"Another mobile device" does not in my opinion suggest that you have multiple mobile devices

I think it does mean exactly that to a native English speaker, I'm afraid. I think you want "If you also use a mobile device, ..."

@andybalaam
Copy link
Member

Updated at https://localazy.com/p/element-web/source-language/_a7632610702617169319 . I was not able to ask for review in localazy, so I asked for review in #element-dev:matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-SAS-Verification O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement Team: Crypto X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants