-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instruct user to open EX app before starting verification #28520
Comments
The user could be using any device to verify it, including another session on the same device, so saying "another mobile device" is very confusing |
Yes, they could. That is why it is says that if you use a mobile device. |
"another mobile device"? I don't have "another mobile device" I have just the one |
Where is the issue with context for why this is not fixed? |
I do not think many users run EW on their mobile device, if that is what you meant. "Another mobile device" does not in my opinion suggest that you have multiple mobile devices - it is another device that is mobile. However, I do not mind alternative wordings which may be more clear. |
Classic Element (Android) doesn't have this issue so it doesn't sound like it's impossible to implement. Is this an iOS specific limitation, or just a Hard Problem™ that isn't going to be attempted to be fixed? |
The underlying issue here is that in order to bootstrap the session verification listeners we need access to the user's identity which is dependant on a keys query response. Normally that would be handled through an olm machine listener but, as I understand it, those get reset often due to missing cross proccess locking. As such, we use sync callbacks as a retry mechanism until we can actually get our hands on a |
I thought the issue was that the notification client (EX) was swallowing the to_device verification request events |
I think it does mean exactly that to a native English speaker, I'm afraid. I think you want "If you also use a mobile device, ..." |
Updated at https://localazy.com/p/element-web/source-language/_a7632610702617169319 . I was not able to ask for review in localazy, so I asked for review in #element-dev:matrix.org |
When verifying the device with another device, the EX app needs to be open before the verification is started, otherwise the request is lost. This is not ideal, but there is no trivial fix for it. Therefore have chosen to instruct the user to open the app.
On EX side there, there is an extra step between selecting another device as means of verification and actually starting the verification. To keep things currently simple on EW, simply update the copy in this modal:
"Verify your identity to access encrypted messages and prove your identity to others. If you use another mobile device, please open the app there before you proceed."
This has already created confusion, thus important to bring some clarity ASAP.
The text was updated successfully, but these errors were encountered: