Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message shown when sender withholds key is misleading #28465

Open
Tracked by #2450
richvdh opened this issue Nov 14, 2024 · 0 comments
Open
Tracked by #2450

Message shown when sender withholds key is misleading #28465

richvdh opened this issue Nov 14, 2024 · 0 comments
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Nov 14, 2024

When a room key is withheld and we receive a withheld message with reason code m.unverified, the recipient sees the following text:

"The sender has blocked you from receiving this message because your device is unverified"

However, the spec for m.unverified says:

  • m.unverified: the user/device was not verified, and the sender is only sharing keys with verified users/devices.

... and indeed, this withheld code is used to indicate when the key is being withheld because the user has not been verified (as well as being used when the key is withheld due to the device has not been verified). The warning is therefore misleading at best.

Ideally these two cases would have different m.withheld codes (for which, see element-hq/element-meta#2621), but in the meantime we should update the text to be more accurate.

See parent issue for wording suggestions.

@dosubot dosubot bot added A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Nov 14, 2024
@dbkr dbkr added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants