-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTD posthog reporting add more properties to captured event #8780
Conversation
b88bc98
to
4d04b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one problem to fix, else it's all good to me.
// now remove from tracked | ||
trackedEventsMap.remove(decryptionFailure.failedEventId) | ||
// mark as already reported | ||
alreadyReported.add(decryptionFailure.failedEventId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alreadyReported
does not seem to be read.
It was used to filter the Events previously (line 140 in previous version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch. I fixed the unit test that was not correctly testing that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Fixes #8779
Refactored the DecryptionFailureTracker so that it can report late decryption and permanent decryptions errors.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist