Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot have @ in authors field #389

Open
malept opened this issue Jun 30, 2021 · 0 comments
Open

Cannot have @ in authors field #389

malept opened this issue Jun 30, 2021 · 0 comments

Comments

@malept
Copy link
Member

malept commented Jun 30, 2021

Problem

If the author field in your package.json file contains an @ (usually in an email address), or you set the authors config option to a value that contains an @ character, running the Windows installer will fail with:

Error:

The '@' character, hexadecimal value 0x40, cannot be included in a name. Line 1, position 40.

Error: Failed with exit code: 1

Having @ in the owners and copyright options (by default, those options use authors) appears to be fine.

Solution

  • Strip out the @ from metadata.authors before writing the nuspec file.
  • Make sure it doesn't affect the owners or copyright default options (as the bug doesn't affect those fields for some reason).
  • Write tests to make sure the above points are followed (only need to check the nuspec file contents, don't need to run through the entire installer process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant