Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should electron-squirrel-startup be included? #20

Open
zeke opened this issue Apr 28, 2018 · 2 comments
Open

Should electron-squirrel-startup be included? #20

zeke opened this issue Apr 28, 2018 · 2 comments

Comments

@zeke
Copy link
Contributor

zeke commented Apr 28, 2018

Hi @imlucas 👋

I just came across electron-squirrel-startup. Do you think it would make sense for this module (update-electron-app) to require and invoke it?

cc @MarshallOfSound
@imlucas
Copy link

imlucas commented Apr 29, 2018

@zeke makes sense to me. It’s overdue for some tlc... @durran has some upcoming auto updates work as well, so either of you do lmk if there are any code warts I can take care of to make this easier.

@zeke
Copy link
Contributor Author

zeke commented Apr 30, 2018

Thanks for the reply 👍

overdue for some tlc

Can you elaborate?

@imlucas imlucas mentioned this issue May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeke @imlucas