Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Universal Apps #121

Open
dgreene-r7 opened this issue Jul 19, 2023 · 1 comment
Open

Support Universal Apps #121

dgreene-r7 opened this issue Jul 19, 2023 · 1 comment

Comments

@dgreene-r7
Copy link

Currently the feed URL is constructed from process.arch which doesn't offer any insight into how the app that's calling it is built. I'm not sure it's possible for the running code to determine how the app has been built.

My sense is that having a matrix of possibilities (darwin + x64, darwin + arm64, darwin + universal) to check would be worthwhile. Obviously this will also require some work in https://github.com/electron/update.electronjs.org to support it; I've filed electron/update.electronjs.org#140 to track that.

@baparham
Copy link

I think in theory we only need universal apps if the user doesn't know what they need to download, but when we are querying for updates, we know the user's architecture, like you suggest, there seems to be something like a preferred order to check:

  • <user's arch>
  • universal
  • finally falling back to x64 (since these can run on the m1s, and maybe what the user originally downloaded anyway).

Have you looked into the code at all to see if this is a straightforward enhancement you could put together a pull request for (both here and at update.electronjs.org)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants