Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release logic misses case where first release was an alpha #30

Open
codebytere opened this issue Dec 14, 2023 · 1 comment
Open

Release logic misses case where first release was an alpha #30

codebytere opened this issue Dec 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@codebytere
Copy link
Member

There's currently a bug where some PRs merged will show no release from the primary comment but correctly show releases for backport PRs and their associated commits.

For example, electron/electron#40634 was merged into main on November 30th, and subsequently backported to 28, 27, and 26. The first release of electron/electron#40634 occurred in v29.0.0-alpha.1, which can be seen in the PR's merge commit electron/electron@b2fcc15.

However, the existing source PR release logic only checks for nightlies and in the release branches specified by trop's backport comments.

We need to augment this logic to account for the first release of a given source PR commit being in a major line prerelease version and not a nightly.

@codebytere codebytere added the bug Something isn't working label Dec 14, 2023
@dsanders11
Copy link
Member

This is a valid issue, but having looked at it a bit I think the example PR in the description, electron/electron#40634, is actually correct - it released first in v29.0.0-nightly.20231130. It's hard to tell in GitHub's interface because apparently they're not sorting the tags they display by tag date, but rather reverse alphabetical semver (stable, nightly, beta, alpha). It was in five nightlies before it hit the alpha.

I found a different PR which was indeed released in an alpha first, and the current logic instead shows a nightly. That's electron/electron#42368, which first released in v32.0.0-alpha.1, but the current logic shows v33.0.0-nightly.20240612.

@dsanders11 dsanders11 self-assigned this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants