You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's currently a bug where some PRs merged will show no release from the primary comment but correctly show releases for backport PRs and their associated commits.
This is a valid issue, but having looked at it a bit I think the example PR in the description, electron/electron#40634, is actually correct - it released first in v29.0.0-nightly.20231130. It's hard to tell in GitHub's interface because apparently they're not sorting the tags they display by tag date, but rather reverse alphabetical semver (stable, nightly, beta, alpha). It was in five nightlies before it hit the alpha.
I found a different PR which was indeed released in an alpha first, and the current logic instead shows a nightly. That's electron/electron#42368, which first released in v32.0.0-alpha.1, but the current logic shows v33.0.0-nightly.20240612.
There's currently a bug where some PRs merged will show no release from the primary comment but correctly show releases for backport PRs and their associated commits.
For example, electron/electron#40634 was merged into main on November 30th, and subsequently backported to 28, 27, and 26. The first release of electron/electron#40634 occurred in
v29.0.0-alpha.1
, which can be seen in the PR's merge commit electron/electron@b2fcc15.However, the existing source PR release logic only checks for nightlies and in the release branches specified by trop's backport comments.
We need to augment this logic to account for the first release of a given source PR commit being in a major line prerelease version and not a nightly.
The text was updated successfully, but these errors were encountered: