Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents property can be a function #25

Merged
merged 2 commits into from
May 4, 2018

Conversation

mnaamani
Copy link
Contributor

@mnaamani mnaamani commented Nov 1, 2017

Could make #22 simpler to do.

@MarshallOfSound
Copy link
Member

Should add this to the docs (README) as well 👍

@mnaamani
Copy link
Contributor Author

Great I will try to update the README today.

@mnaamani
Copy link
Contributor Author

Added contents option to README with example of using both an array and function.

@mnaamani
Copy link
Contributor Author

PR should be ready for final review
@MarshallOfSound

@MarshallOfSound
Copy link
Member

@mnaamani It looks good to me but I don't have powers over this repo 😆 Gonna need a review / merge / release from @imlucas

@alexanderturinske
Copy link
Contributor

@imlucas Plz!

@MarshallOfSound
Copy link
Member

cc @durran @imlucas

Anything we can do to get this looked at? If you don't have the bandwidth to look at this would you mind adding me or @malept as collaborators on this repository. This module is heavily depended on by users of electron-forge over in electron-userland and we'd love to help keep it moving forward.

@imlucas imlucas merged commit 0f801a5 into electron-userland:master May 4, 2018
@imlucas
Copy link
Contributor

imlucas commented May 4, 2018

Sorry about that! Published in electron-installer-dmg@1.0.0

@MarshallOfSound @malept So this doesn't happen again, would it make sense to transfer this repo and npm over to electron?

@malept
Copy link
Member

malept commented May 4, 2018

@imlucas We can definitely assist in transferring the repo/NPM package over to the electron-userland org, assuming you're OK with the org guidelines.

@imlucas
Copy link
Contributor

imlucas commented May 11, 2018

@malept

For modules that have grown beyond the scope their original creators intended this organization provides a governance structure and neutral ownership model to help modules get new contributors and maintainers.

Sounds like the shoe fits :) How do we get started on the transfer? I have a number of these electron related modules and just don't have the time to maintain. There are roughly 8 that could be candidates to transfer. Have a look and lmk if there is anything else of interest.
https://github.com/mongodb-js?q=electron

cc @zeke per electron/update-electron-app#20

@malept
Copy link
Member

malept commented May 11, 2018

@imlucas let's move this discussion over to the welcome repo: electron-userland/welcome#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants