feat(web): add future price

[silkeholmebonnen]

Issue

AVO-455

Description

This PR adds a section to the price card that shows future prices for the zones that we have future price for (nordpool zones).

Preview

Double check

• I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

[silkeholmebonnen]

Feel free to take a look at the future price @tonypls @Alportan @cadeban 🌞

[silkeholmebonnen]

I'll just do a few changes @VIKTORVAV99. I found a bug that I will fix and we decided in the office that we will try and switch to MWh.

[VIKTORVAV99]

I'll just do a few changes @VIKTORVAV99. I found a bug that I will fix and we decided in the office that we will try and switch to MWh.

Sounds good, I'll probably not have time to take a deep look at this until tomorrow or Wednesday. 🙂

[VIKTORVAV99]

I'll just do a few changes @VIKTORVAV99. I found a bug that I will fix and we decided in the office that we will try and switch to MWh.

@Alportan there is also a issue open here #7219 to show prices in Euro Cent per KWh, which might be an option. But I agree on doing MWh now and then we can look into cents later on.

[Alportan]

I'll just do a few changes @VIKTORVAV99. I found a bug that I will fix and we decided in the office that we will try and switch to MWh.

@Alportan there is also a issue open here #7219 to show prices in Euro Cent per KWh, which might be an option. But I agree on doing MWh now and then we can look into cents later on.

Nice! 🙌 Let's start with switching back to MWh for now.

It's sneaky, but this way we can monitor incoming feedback the other way (people being upset about switching back to MWh instead of kWh) then we have some more evidence for the need of a toggle between the 2 views. 🥷

[silkeholmebonnen]

It should be ready for review now. The only thing missing is the highligt of the current hour (as seen here), but that could also be done in v2. I will not have time to implement this until Thursday, so you are welcome to do it @VIKTORVAV99, or I can do it Thursday, or we can wait until v2 - whichever you prefer.

[VIKTORVAV99]

Looks really good!

Some minor comments but overall it's a pretty clean implementation!

[VIKTORVAV99]

I did notice a blocker for this but it's related to the backend, basically we need to double check that we have a license for the zone before we send the day ahead data. If you look at Croatia for example then we hide the data in the graph due to license issues but you can still see the day ahead prices.

[silkeholmebonnen]

I did notice a blocker for this but it's related to the backend, basically we need to double check that we have a license for the zone before we send the day ahead data. If you look at Croatia for example then we hide the data in the graph due to license issues but you can still see the day ahead prices.

Until we change it in the backend we would be able to do a simple check like this in the frontend to ensure that we only show future price if the price is not disabled:
{!isPriceDisabled && <FuturePrice futurePrice={futurePrice} />}

Do you think we should do that for now?

[VIKTORVAV99]

I did notice a blocker for this but it's related to the backend, basically we need to double check that we have a license for the zone before we send the day ahead data. If you look at Croatia for example then we hide the data in the graph due to license issues but you can still see the day ahead prices.

Until we change it in the backend we would be able to do a simple check like this in the frontend to ensure that we only show future price if the price is not disabled:

{!isPriceDisabled && <FuturePrice futurePrice={futurePrice} />}

Do you think we should do that for now?

Not sure that's good enough, we would still send the data. But it shouldn't be too hard to do it in the backend as we are already doing it for the other price information.

[silkeholmebonnen]

I did notice a blocker for this but it's related to the backend, basically we need to double check that we have a license for the zone before we send the day ahead data. If you look at Croatia for example then we hide the data in the graph due to license issues but you can still see the day ahead prices.

Until we change it in the backend we would be able to do a simple check like this in the frontend to ensure that we only show future price if the price is not disabled:
{!isPriceDisabled && <FuturePrice futurePrice={futurePrice} />}
Do you think we should do that for now?

Not sure that's good enough, we would still send the data. But it shouldn't be too hard to do it in the backend as we are already doing it for the other price information.

Okay, I will change it in the backend ASAP:)

[Alportan]

Not sure that's good enough, we would still send the data. But it shouldn't be too hard to do it in the backend as we are already doing it for the other price information.

How long do you estimate it would take to implement the backend changes for checking the license before sending day-ahead data? 🙋

Given that we're getting more user feedback requesting prices in MWh instead of kWh (and now in the form of appstore reviews), we could consider cherry-picking just that change and release it separately if the full set of changes wouldn't be as straightforward. 💡

Alternatively, if the backend changes are quick, we should proceed with the full implementation. 💪

What do you think the best approach would be? 🙌 @VIKTORVAV99 @silkeholmebonnen

[VIKTORVAV99]

Not sure that's good enough, we would still send the data. But it shouldn't be too hard to do it in the backend as we are already doing it for the other price information.

How long do you estimate it would take to implement the backend changes for checking the license before sending day-ahead data? 🙋

Given that we're getting more user feedback requesting prices in MWh instead of kWh (and now in the form of appstore reviews), we could consider cherry-picking just that change and release it separately if the full set of changes wouldn't be as straightforward. 💡

Alternatively, if the backend changes are quick, we should proceed with the full implementation. 💪

What do you think the best approach would be? 🙌 @VIKTORVAV99 @silkeholmebonnen

They just got merged 😉

[Alportan]

Not sure that's good enough, we would still send the data. But it shouldn't be too hard to do it in the backend as we are already doing it for the other price information.

How long do you estimate it would take to implement the backend changes for checking the license before sending day-ahead data? 🙋
Given that we're getting more user feedback requesting prices in MWh instead of kWh (and now in the form of appstore reviews), we could consider cherry-picking just that change and release it separately if the full set of changes wouldn't be as straightforward. 💡
Alternatively, if the backend changes are quick, we should proceed with the full implementation. 💪
What do you think the best approach would be? 🙌 @VIKTORVAV99 @silkeholmebonnen

They just got merged 😉

Then maybe we can soon release this soon 🤩 👏 Let's prioritise getting it out there! 😎

[VIKTORVAV99]

LGTM! 🎉

I look forward to spending hours and hours looking at prices!

Nice work!