Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing exchange config between France and Andorra #7243

Open
VIKTORVAV99 opened this issue Sep 28, 2024 · 5 comments · May be fixed by crovebi/electricitymaps-contrib#1
Open

Missing exchange config between France and Andorra #7243

VIKTORVAV99 opened this issue Sep 28, 2024 · 5 comments · May be fixed by crovebi/electricitymaps-contrib#1
Assignees
@jackkjenkins
Labels
good first issue help wanted

Comments

@VIKTORVAV99
Copy link
Member

Description

There are a exchange between France and Andorra but we are missing this in the app.

The first step to get it added will be to create a exchange config for it.
@AJDelusion
Copy link

The connection from France to Jersey is also missing.

@VIKTORVAV99
Copy link
Member Author

The connection from France to Jersey is also missing.

Would you mind creating a new issue for that?

crovebi added a commit to crovebi/electricitymaps-contrib that referenced this issue Sep 30, 2024
@crovebi
Add Andorra<->France exchange config (electricitymaps#7243)
996d357 
* Add connection to map

* Include Andorra France exchange to FR parser
@crovebi crovebi linked a pull request Sep 30, 2024 that will close this issue
Open
@jackkjenkins
Copy link
Contributor

Hi @VIKTORVAV99 & ElectricityMaps Team,

I am interested in working on this issue. It's my first time contributing to this project, and I've had a look through closed PRs regarding config files and I think I understand how this would need to be implemented (in particular, I've looked at this Issue #7270 and PR #7298).

Can I please be assigned to this issue, and is there anything else that I need to know before starting?

Thanks!

@VIKTORVAV99
Copy link
Member Author

@jackkjenkins I've assigned you the issue and I don't think there is anything else you need to know if you have already looked through those issues.

@jackkjenkins jackkjenkins mentioned this issue Oct 16, 2024
Merged
2 tasks
@jackkjenkins
Copy link
Contributor

Hi @VIKTORVAV99,

I've added a PR for this issue. I wasn't able to add a reviewer so could you please add one for me if it is ready for review.
If there's any issues please let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackkjenkins jackkjenkins

Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Andorra<->France exchange config (#7243) crovebi/electricitymaps-contrib
3 participants
@VIKTORVAV99 @AJDelusion @jackkjenkins