Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Lookup Join meta issue #116208

Open
9 of 36 tasks
costin opened this issue Nov 4, 2024 · 1 comment · Fixed by #116515
Open
9 of 36 tasks

ESQL: Lookup Join meta issue #116208

costin opened this issue Nov 4, 2024 · 1 comment · Fixed by #116515
Assignees
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@costin
Copy link
Member

costin commented Nov 4, 2024

Description

Meta ticket around the main implementation topics required for lookup join

Compute

  • Make field extractor work with LookupOperators (keep field extraction in one place)
  • Bifurcate join operator/allow other operators between join and Lookup source (eval, filter, etc..)
  • Align LookupJoin and LookupJoinExec - the first allows branching, the second does not.
  • Some kind of scale test

Maybe

  • obtain IndexMode inside IndexResolver (FieldCaps)
    Later
  • refactor JoinConfig into general Expression
@costin costin self-assigned this Nov 4, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@costin costin linked a pull request Nov 8, 2024 that will close this issue
costin added a commit that referenced this issue Nov 20, 2024
First PR for adding LOOKUP JOIN in ESQL.
Introduces grammar and wires the main building blocks to execute a query; follow-ups are required (see #116208 for more details).

Co-authored-by: Nik Everett <nik9000@users.noreply.github.com>
@costin costin reopened this Nov 20, 2024
costin added a commit to costin/elasticsearch that referenced this issue Nov 20, 2024
First PR for adding LOOKUP JOIN in ESQL.
Introduces grammar and wires the main building blocks to execute a query
 ; follow-ups are required (see elastic#116208 for more details).

Co-authored-by: Nik Everett <nik9000@users.noreply.github.com>
(cherry picked from commit bc785f5)
elasticsearchmachine pushed a commit that referenced this issue Nov 20, 2024
First PR for adding LOOKUP JOIN in ESQL.
Introduces grammar and wires the main building blocks to execute a query
 ; follow-ups are required (see #116208 for more details).

Co-authored-by: Nik Everett <nik9000@users.noreply.github.com>
(cherry picked from commit bc785f5)
rjernst pushed a commit to rjernst/elasticsearch that referenced this issue Nov 20, 2024
First PR for adding LOOKUP JOIN in ESQL.
Introduces grammar and wires the main building blocks to execute a query; follow-ups are required (see elastic#116208 for more details).

Co-authored-by: Nik Everett <nik9000@users.noreply.github.com>
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
First PR for adding LOOKUP JOIN in ESQL.
Introduces grammar and wires the main building blocks to execute a query; follow-ups are required (see elastic#116208 for more details).

Co-authored-by: Nik Everett <nik9000@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants