Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure_threshold parsing when value is coming from fleet #6152

Open
pchila opened this issue Nov 27, 2024 · 2 comments
Open

Fix failure_threshold parsing when value is coming from fleet #6152

pchila opened this issue Nov 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pchila
Copy link
Member

pchila commented Nov 27, 2024

While investigating #6049 I tried to set the failure_threshold using fleet override API, however this is parsed as a float64 by agent which is not supported at the moment, for example:

PUT kbn:/api/fleet/agent_policies/<policy_id>
{
   "name": <policy_name>,
   "namespace": "default",
   "overrides": {
       "agent": {
            "monitoring": {
                "failure_threshold": 5
            }
       }
   }
}

Optionally figure out how to reset the failure_threshold to default from fleet, agent should probably check if there's a monitoring section coming from fleet but no failure_threshold key and reset its monitoring failure_threshold

@pchila pchila self-assigned this Nov 27, 2024
@pchila pchila added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@cmacknz
Copy link
Member

cmacknz commented Nov 27, 2024

I think this is probably a case of #2522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

3 participants