Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable race detector #13827

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Aug 2, 2024

Motivation/summary

Unfortunately we can only enable the race detector for ci and unit tests.
system-tests are building the apm-server binary (CGO disabled by default) so we can't enable the race detector as it requires cgo.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Unfortunately we can only enable the race detector for ci and unit
tests.
system-tests are building the apm-server binary (CGO disabled by default)
so we can't enable the race detector as it requires cgo.
@kruskall kruskall requested a review from a team as a code owner August 2, 2024 23:03
Copy link
Contributor

mergify bot commented Aug 2, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 2, 2024
the make task doesn't disable cgo so be consistent in ci
1pkg
1pkg previously approved these changes Aug 2, 2024
@marclop
Copy link
Contributor

marclop commented Aug 12, 2024

There's a test that should probably be fixed, seems like a sync problem.

@v1v v1v added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 10, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@v1v v1v added the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@kruskall
Copy link
Member Author

This uncovered a race condition in elastic-agent-client lib: elastic/elastic-agent-client#125

PR blocked until that's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants