Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x release process publishes to npm with "latest" dist-tag, not "latest-3" dist-tag #4307

Open
trentm opened this issue Nov 5, 2024 · 1 comment · Fixed by #4308
Open
Assignees

Comments

@trentm
Copy link
Member

trentm commented Nov 5, 2024

The recent 3.52.2 release took the "latest" npm dist-tag. That's wrong. "latest" should always be the current main release branch (currently 4.x), else latest-$major.

@trentm trentm self-assigned this Nov 5, 2024
@trentm
Copy link
Member Author

trentm commented Nov 5, 2024

I accidentally blew this away in the other updates to the release.yml workflow in #4304

       - name: npm publish
         run: |-
-          echo "//registry.npmjs.org/:_authToken=${{ env.NPMJS_TOKEN }}" > .npmrc
-          npm publish --tag="latest-3" --otp=${{ env.TOTP_CODE }}
+          echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc
+          npm publish --provenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant