Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fastify instr to avoid new deprecation warnings #3634

Open
trentm opened this issue Sep 22, 2023 · 0 comments
Open

update fastify instr to avoid new deprecation warnings #3634

trentm opened this issue Sep 22, 2023 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning. good first issue

Comments

@trentm
Copy link
Member

trentm commented Sep 22, 2023

This change in fastify@4.23.0 adds a deprecation warning for accessing req.routerMethod and req.routerPath.

* 59050e57 - feat: access handler name add properties to req route options (#4470)

My guess (haven't tried yet) is that our instrumentation will cause deprecation warnings for users using this fastify and later. We should adjust to using the newer fields if available.
@trentm trentm changed the title update fastify instr update fastify instr to avoid new deprecation warnings Sep 22, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning. good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentm