Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 826] changes to metadata.cloud.project.* fields collected for GCP #3614

Closed
elastic-apm-tech opened this issue Sep 6, 2023 · 0 comments · Fixed by #3618
Closed

[META 826] changes to metadata.cloud.project.* fields collected for GCP #3614

elastic-apm-tech opened this issue Sep 6, 2023 · 0 comments · Fixed by #3618
Labels
8.11-candidate

Comments

@elastic-apm-tech
Copy link

See meta issue for the description and details:
@elastic-apm-tech elastic-apm-tech mentioned this issue Sep 6, 2023
Closed
7 tasks
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 6, 2023
@trentm trentm added 8.11-candidate and removed agent-nodejs Make available for APM Agents project planning. labels Sep 6, 2023
trentm added a commit that referenced this issue Sep 8, 2023
@trentm
fix: changes to metadata.cloud.project.* fields collected for GCP
19f96ca 
- cloud.project.id per the shared APM spec change
- fix the bignum parsing of instance.id (we were losing precision before
  this change)
- add instance.name (missed in the original impl?)

Closes: #3614
@trentm trentm mentioned this issue Sep 8, 2023
Merged
trentm added a commit that referenced this issue Sep 13, 2023
@trentm
fix: changes to metadata.cloud.project.* fields collected for GCP (#3618
e07d826 
)

- cloud.project.id per the shared APM spec change
- fix the bignum parsing of instance.id (we were losing precision before
  this change)
- add instance.name (missed in the original impl)

Closes: #3614
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this issue Aug 20, 2024
@trentm @fpm-peter
fix: changes to metadata.cloud.project.* fields collected for GCP (el…
7e65a0d 
…astic#3618)

- cloud.project.id per the shared APM spec change
- fix the bignum parsing of instance.id (we were losing precision before
  this change)
- add instance.name (missed in the original impl)

Closes: elastic#3614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.11-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changes to metadata.cloud.project.* fields collected for GCP elastic/apm-agent-nodejs
2 participants
@trentm @elastic-apm-tech