Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and re-grok using 'backport' for backporting changes from main to 3.x #3572

Closed
trentm opened this issue Aug 9, 2023 · 2 comments
Closed

update and re-grok using 'backport' for backporting changes from main to 3.x #3572

trentm opened this issue Aug 9, 2023 · 2 comments
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
next-major

Comments

@trentm
Copy link
Member

trentm commented Aug 9, 2023

We have an old backport in our devDeps and mention of backporting in CONTRIBUTING.md. We haven't used it in ages. We should update and learn and discuss if and how we want to use the tool. There is also some GitHub actions tooling we could consider to allow using PR labels to initial backporting.

https://github.com/sqren/backport
@trentm trentm added this to the next-major milestone Aug 9, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 9, 2023
@trentm
Copy link
Member Author

trentm commented Sep 26, 2023

My inclination currently is to remove the backport dep. Given that we don't plan to do much backporting to 3.x, I don't think we need any process/tooling beyond creating PRs targeting "3.x" with one or more git cherry-picks.

@trentm
Copy link
Member Author

trentm commented Sep 26, 2023

We could add it back later if we find we are doing at all frequent backporting.

trentm added a commit that referenced this issue Sep 26, 2023
@trentm
chore(dev): drop backport tool
3744ced 
Refs: #3572
@trentm trentm mentioned this issue Sep 26, 2023
Merged
trentm added a commit that referenced this issue Sep 26, 2023
@trentm
chore(dev): drop backport tool (#3645)
e5e014f 
Refs: #3572
@trentm trentm closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this issue Aug 20, 2024
@trentm @fpm-peter
chore(dev): drop backport tool (elastic#3645)
22f5f00 
Refs: elastic#3572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
Status: Done
Milestone
next-major
Development

No branches or pull requests
1 participant
@trentm