Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META 806] Create dashboard for runtime metrics #3439

Open
elastic-apm-tech opened this issue Jun 22, 2023 · 6 comments
Open

[META 806] Create dashboard for runtime metrics #3439

elastic-apm-tech opened this issue Jun 22, 2023 · 6 comments
Assignees
Labels
8.10-candidate agent-nodejs Make available for APM Agents project planning.
Milestone

Comments

@elastic-apm-tech
Copy link

See meta issue for the description and details:

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 22, 2023
@trentm trentm added this to the 8.10 milestone Jun 26, 2023
@trentm
Copy link
Member

trentm commented Aug 14, 2023

@AlexanderWert Does https://github.com/elastic/kibana/pull/157724/files#diff-b0f9281b29e17f3aa9406728abcfb41a649247dcf8ea1fb0dc801ad4439cd783 already provide a dashboard for Node.js runtime metrics? That "nodejs.json" file includes \"sourceField\":\"nodejs.memory.heap.used.bytes\", for example.

Granted this doesn't handle any OTel SDK possible metrics.

@trentm
Copy link
Member

trentm commented Aug 14, 2023

Does https://github.com/elastic/kibana/pull/157724/files#diff-b0f9281b29e17f3aa9406728abcfb41a649247dcf8ea1fb0dc801ad4439cd783 already provide a dashboard for Node.js runtime metrics?

Answering my own question: Yes, it does. That dashboard is clearly there in my local-dev 8.10 kibana.
Screen Shot 2023-08-14 at 4 17 55 PM

Alex, please correct me if I'm wrong.
Our goal for this issue for Node.js then is to:

  1. add a dashboard for agentName === 'opentelemetry/nodejs' for default (or common) Node.js runtime metrics provided by the OTel JS SDK; and
  2. possibly review what you have added with the nodejs.json dashboard.

(/cc @david-luna)

@estolfo estolfo modified the milestones: 8.10, 8.11 Aug 28, 2023
@david-luna david-luna self-assigned this Sep 26, 2023
@david-luna
Copy link
Member

Found the host-metrics Otel package is sending bad measurements for CPU utilization. Filed an issue
open-telemetry/opentelemetry-js-contrib#1718

@david-luna
Copy link
Member

PR on apm-contrib repo to add memory metrics which could be reused in other languages

elastic/apm-contrib#84

@david-luna
Copy link
Member

Alignment in process.cpu and system.cpu metrics at semconv level has been suggested
open-telemetry/semantic-conventions#563

@david-luna
Copy link
Member

david-luna commented Nov 21, 2023

PR to fix process.cpu.time & process.cpu.utilization
open-telemetry/opentelemetry-js-contrib#1785

There is a PR to update process semconv which may change the attribute names. The PR above is prepared to receive the necessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10-candidate agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

4 participants