Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve package resolution at agent.start() #3397

Open
david-luna opened this issue Jun 1, 2023 · 1 comment
Open

chore: improve package resolution at agent.start() #3397

david-luna opened this issue Jun 1, 2023 · 1 comment
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@david-luna
Copy link
Member

david-luna commented Jun 1, 2023 •
edited
Loading

When the agent starts with logLevel = trace the agent tries to resolve the package info to display some extra data by doing a simple file lookup in the running scripts folder. It is possible that the script is not placed alongside the package file but it might be on a upper level.

We need to improve the lookup process to cover this situation. For more context see this comment
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 1, 2023
@trentm
Copy link
Member

trentm commented Jun 1, 2023

We could probably just add .dependencies to findPkgInfo and re-use that. Perhaps take findPkgInfo out of config.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trentm @david-luna