the bin file airupnp and aircast in AirConnect-dsm7-x86_64-1.8.3-20240327.spk are broken

[seiry]

Describe the bug

I downloaded the spk from the pre-release, and it won's start after I installed. And with no log.

https://github.com/eizedev/AirConnect-Synology/releases/tag/1.8.3-20240327

I checked the bin file in the dsm, which showed it was not a valid ELF

And I unpacked the spk file AirConnect-dsm7-x86_64-1.8.3-20240327.spk in mac.

both of the 2 files are not valid ELF bins.

other context

to compare, the bin file in https://github.com/eizedev/AirConnect-Synology/releases/tag/1.7.0-20240115 and #106 (comment) is good.

And I checked the artifacts in https://github.com/eizedev/AirConnect-Synology/actions/runs/8448579672 , I think there may be something wrong in the action pipeline.

Package

https://github.com/eizedev/AirConnect-Synology/releases/tag/1.8.3-20240327

• package name: AirConnect-dsm7-x86_64-1.8.3-20240327.spk

[eizedev]

Thanks @seiry, some other users also realized this. I need to find a few minutes to investigate the problem.
There may be two problems, one in the detection in the start-stop-status (src/dsm7/scripts subfolder) script and one in the binary itself, as you suspect.
Therefore i changed it to pre-release until i investigated it.(Only a "problem" due to time (Easter etc.))

Also, the GitHub action is not completely finished, I would like to publish releases automatically and add some more validation. That's why I'm currently only making it available for me in the artifacts (and not publishing the packages automatically) until I'm finished with it.

Trackback: #106 #79 #105

[seiry]

oh hey @eizedev , I did some research and It's release-downloader broke the extract files.
downgrade it to robinraju/release-downloader@v1.8 would fix.
robinraju/release-downloader#689

And thank you for your cool work! lol

[eizedev]

Really cool find! Thanks @seiry
Would you like to open a pull request? Then i can merge it and you will be named as contributor. if not, i will just "install" the fix later on that day (robinraju/release-downloader@v1.8)

[seiry]

yeah, I've already opened one.
#108
Also, I enhanced the publish flow. Now when publish a tag, will trigger the build pipeline, and then add the spks to the release.
@eizedev