Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Replace ReplacementManager #8

Open
cjayross opened this issue Jul 7, 2019 · 1 comment
Open

Replace ReplacementManager #8

cjayross opened this issue Jul 7, 2019 · 1 comment

Comments

@cjayross
Copy link
Contributor

cjayross commented Jul 7, 2019

Having a global data structure for managing array replacement is not efficient and causes conflicts in multithreading/multiprocessing. It would be best to find a way to construct the necessary replacement dictionary from within expand_tensor from the arguments of the passed expression.
@cjayross
Copy link
Contributor Author

cjayross commented Jul 7, 2019 •
edited
Loading

Yeah, this needs to be done ASAP. ReplacementManager was a bad idea from the start.

Edit: Finished. It wasn't that difficult. I will submit a PR soon.

@cjayross cjayross mentioned this issue Jul 7, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjayross