From 3adb6ec86db39f01145c7f435e7dcb50e2988e8c Mon Sep 17 00:00:00 2001 From: William Killerud Date: Mon, 19 Aug 2024 10:03:13 +0200 Subject: [PATCH] chore: exclude node 18 on windows on ci For an unknown reason the upload tests fail on Node 18 on Windows with an ECONNRESET from node-fetch. Debugging hasn't revealed any probable cause. - The fixture readable stream works as expected on Node 18 on Windows - Other requests to the server work as expected Refactoring to use native fetch means we lose the option to override the origin hostname, which we use to test server validation. --- .github/workflows/test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ec8a470..71fe57c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,6 +14,9 @@ jobs: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] node-version: [18, 20] + exclude: + - os: windows-latest + node-version: 18 # upload tests fail with ECONNRESET for unknown reasons on Node 18 on Windows runs-on: ${{ matrix.os }} steps: