Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach locations to AST with attachSourcePosSource #5

Open
coord-e opened this issue Feb 15, 2020 · 0 comments
Open

attach locations to AST with attachSourcePosSource #5

coord-e opened this issue Feb 15, 2020 · 0 comments
Labels
performance Something related to performance refactoring Improvements of internals

Comments

@coord-e
Copy link
Collaborator

coord-e commented Feb 15, 2020

We currently use getSourcePos to obtain current source location during parsing and annotate AST with it, but as the documentation says, getSourcePos is slow to use frequently. Using getOffset to annotate with offsets first and convert them to SourcePos later with attachSourcePosSource would be faster.

@coord-e coord-e added refactoring Improvements of internals performance Something related to performance labels Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Something related to performance refactoring Improvements of internals
Projects
None yet
Development

No branches or pull requests

1 participant