Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix z-index for reader searchbar #2662

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix z-index for reader searchbar #2662

wants to merge 1 commit into from

Conversation

arthur-lemeur
Copy link
Collaborator

Fixes #2661

Z-index set to "100" to match the z-index of the dialogs so when they're opened they come on top of it.

panaC
panaC approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@panaC panaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your zindex solution is a bit "sticking a finger in the air" :) Have you hard-tested all possible UI interactions ?

@arthur-lemeur
Copy link
Collaborator Author

I tested it with the publication info dialog, the reader menu and and reader settings (both in modal and docked mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panaC panaC panaC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search bar displayed on top of publication information/navigation/reader settings window in reader window
2 participants
@arthur-lemeur @panaC