Diff server should return a 503 status for upstream 503 responses #20
Labels
enhancement
New feature or request
server
Specific to the diffing server, rather than diff algorithms
The diff server usually handles upstream errors (I.e. the result of fetching the URL for either the
a
orb
parameters is an error) by returning a 502 (bad gateway) status. However, if the upstream response was a 503 (service unavailable) status, we should probably return the same, including the upstreamRetry-After
response header, if present.503 is often used to tell the requesting server to slow down, so it would be helpful to send that info back to the downstream server, since are just acting dumb in the middle.
In fact, if an upstream response comes back as any error with a
Retry-After
header, we should probably send along that header to the downstream client.(We sometimes get this status from S3 when running imports and auto analysis, so it would be nice to handle it better.)
The text was updated successfully, but these errors were encountered: