Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add label checking workflow #112

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature: Add label checking workflow #112

wants to merge 5 commits into from

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Oct 29, 2024 •
edited
Loading

Ensures ATS Approval before merge to develop

Issue

It is unclear at the moment when PR's can be merged, particularly with ATS.

Resolution

This adds a workflow step to check if the ATS Approved or the No approval needed label is added to the PR.
If not it will fail, and prevent merges.

@HCookie HCookie self-assigned this Oct 29, 2024
@HCookie HCookie added No approval needed No approval needed by ATS ATS approved Approved by ATS and removed No approval needed No approval needed by ATS ATS approved Approved by ATS labels Oct 29, 2024
@HCookie HCookie changed the title Add new label checking workflow Feature: Add label checking workflow Oct 29, 2024
@HCookie HCookie marked this pull request as ready for review October 29, 2024 12:43
@HCookie HCookie marked this pull request as draft October 29, 2024 12:53
@HCookie HCookie marked this pull request as ready for review October 29, 2024 12:57
@HCookie HCookie added the enhancement New feature or request label Oct 29, 2024
@mchantry mchantry added the ECMWF label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theissenhelen theissenhelen Awaiting requested review from theissenhelen theissenhelen is a code owner

@JesperDramsch JesperDramsch Awaiting requested review from JesperDramsch JesperDramsch is a code owner

@gmertes gmertes Awaiting requested review from gmertes gmertes is a code owner

@b8raoult b8raoult Awaiting requested review from b8raoult b8raoult is a code owner

@floriankrb floriankrb Awaiting requested review from floriankrb floriankrb is a code owner

@anaprietonem anaprietonem Awaiting requested review from anaprietonem anaprietonem is a code owner

@JPXKQX JPXKQX Awaiting requested review from JPXKQX JPXKQX is a code owner

@mchantry mchantry Awaiting requested review from mchantry mchantry is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@HCookie HCookie

Labels
ECMWF enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HCookie @mchantry