Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] improved configuration and data structures #1

Open
2 of 6 tasks
theissenhelen opened this issue Jun 11, 2024 · 0 comments · May be fixed by #157
Open
2 of 6 tasks

[FEATURE] improved configuration and data structures #1

theissenhelen opened this issue Jun 11, 2024 · 0 comments · May be fixed by #157
Assignees
Labels
enhancement New feature or request

Comments

@theissenhelen
Copy link
Collaborator

theissenhelen commented Jun 11, 2024

Is your feature request related to a problem? Please describe.

Currently, configurations are dealt with purely using yaml files. It would be advantageous to have a solution that is more readable and allows e.g. type checking or and auto-completion in the IDE. Ideally, the solution would also implement validation. This should also integrate with Hydra configuration management (see config Store).

Describe the solution you'd like

Upgrade configs using the following steps:

  • implement Config Stores with dataclasses
  • Upgrade to pydantic
  • assess how restrictive rules should be
  • add documentation

Check if necessary to refactor to a new API, possible steps:

  • Refactor model and graph into a hierarchical architecture config
  • Refactor data and data loader

Describe alternatives you've considered

Additional context

No response

Organisation

No response

@theissenhelen theissenhelen added the enhancement New feature or request label Jun 11, 2024
@theissenhelen theissenhelen self-assigned this Jun 11, 2024
@theissenhelen theissenhelen linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant