Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reorder sort string, which sorts variables alphabetically. #144

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

einrone
Copy link

@einrone einrone commented Nov 21, 2024

Quick summary:
Added another reordering option reorder="sort" which sorts the variables alphabetically to enable transfer learning for stretched grid.

Why, and what is the purpose?

During transfer learning of stretched-grid model, the cutout and the option adjust='all' functionality is used. This will result that the combined dataset (ds1 and ds2) will have their variable list sorted alphabetically. However, then the pretrained model
needs to follow this type of sorting. This implementation will reorder the variable list to sort them alphabetically, hence enabling transfer learning when use multiple datasets when using reorder='sort'.

I have done some test, and also created some units tests, but unsure on where to put LAM dataset in order to make the testing work. For now I will submit this as a draft PR, if unit test is needed I will also include them.

@FussyDuck
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants