Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Material renderer set to Material UI v5 #1805

Closed
sdirix opened this issue Sep 20, 2021 · 4 comments · Fixed by #1812
Closed

Update React Material renderer set to Material UI v5 #1805

sdirix opened this issue Sep 20, 2021 · 4 comments · Fixed by #1812
Assignees
Milestone

Comments

@sdirix
Copy link
Member

sdirix commented Sep 20, 2021

Is your feature request related to a problem? Please describe.

Material UI v5 has some breaking changes, most notably the import paths.

Describe the solution you'd like

Update the React Material renderer set to Material UI v5

Describe alternatives you've considered

Adjust React Material renderer set to be compatible with Material UI v4 and v5. However this requires additional effort and may have consequences on the renderer set architecture.

Framework

React

RendererSet

Material

Additional context

https://next.material-ui.com/guides/migration-v4/

@lcanavesio
Copy link

Hi @sdirix
I use jsonforms/packages/material
Have an estimated date to update to mui 5?

@sdirix
Copy link
Member Author

sdirix commented Nov 9, 2021

Hi @lcanavesio, we're actively working on it, see #1812. It'll probably be part of the next prerelease and definitely part of the 3.0 release.

I don't like to commit to specific dates, however my best guess is the MUI update should be in a (pre)release within November.

@lcanavesio
Copy link

Hi @lcanavesio, we're actively working on it, see #1812. It'll probably be part of the next prerelease and definitely part of the 3.0 release.

I don't like to commit to specific dates, however my best guess is the MUI update should be in a (pre)release within November.

Thanks for answering @sdirix

I take the opportunity to tell you that the text input when deleting the data with keyboard backspace <-- ; it is not required again but if I press the clean button yes. When deleting it does not reassign undefinded when it is empty

https://jsonforms.io/examples/basic -> Occupation*

Thanks for everything

@sdirix
Copy link
Member Author

sdirix commented Nov 9, 2021

I take the opportunity to tell you that the text input when deleting the data with keyboard backspace <-- ; it is not required again but if I press the clean button yes. When deleting it does not reassign undefinded when it is empty

This is currently by design. We are considering changing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants