Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringSettingsProperty Should be Renamed #43

Open
kerner1000 opened this issue Sep 30, 2019 · 2 comments
Open

StringSettingsProperty Should be Renamed #43

kerner1000 opened this issue Sep 30, 2019 · 2 comments
Labels
api-change Marks an issue that would most-likeley requires an API change enhancement New feature or request
Milestone
0.9.x

Comments

@kerner1000
Copy link
Contributor

This annotation makes only sense if the String should be regex validated. For a simple string property, this is not needed.

Hence, it should be renamed to RegexString(Property), for example.
This was referenced Sep 30, 2019
Closed
Merged
@laeubi
Copy link
Member

laeubi commented Sep 30, 2019

In fact it is also used to show a multi-line text field in the ui where each line is validated against the given regexp.

@kerner1000
Copy link
Contributor Author

Each line separately?

@laeubi laeubi added api-change Marks an issue that would most-likeley requires an API change enhancement New feature or request labels Oct 15, 2019
@laeubi laeubi added this to the 0.9.x milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-change Marks an issue that would most-likeley requires an API change enhancement New feature or request
Projects
None yet
Milestone
0.9.x
Development

No branches or pull requests
2 participants
@laeubi @kerner1000